[Psi-devel] PATCH: Re: Presence as empty message events

Mickael Remond mickael.remond at erlang-fr.org
Mon Apr 11 14:19:50 PDT 2005


Marian Cerny a écrit :
> Now
> 
> 	(type != "available")
> 
> is unnecesarry and only lowers readibility of the code, not true?

Yes, you are right. There is still the case of the probe type we should 
not be there and the case of type that cannot be fixed.
I was thinking of adding a final else clause that return true would be 
even better to do nothing for unknown case.
But that's probably too picky. You are right that removing the test 
(type != "available") is even better.

-- 
Mickaël Rémond
  http://www.erlang-projects.org/


More information about the Psi-devel-affinix.com mailing list