[Psi-devel] [PATCH] Merge 'Configure toolbars' inside the options dialog

Francisco Joaquín Rodríguez Prados prados at gmail.com
Tue Apr 19 16:34:01 PDT 2005


Here there is a patch for this task:

http://psi-im.org/flyspray/index.php?do=details&id=289

There are a lot of things that still have to be done. Actually the
only thing that patch makes is to embbed the dialog in the options
window.

But some files should be deleted at this point, because there are not
used anymore (a class is unuseful before the merging) and some other
should be renamed, to make things clearer.

http://www.subtrama.net/psi-dev/embedded-toolbar-dlg.diff

The following filenames should be changed:

- rename psi/src/options/toolbardlg.cpp to opt_toolbars.cpp
- rename psi/src/options/toolbardlg.h to opt_toolbars.h
- rename psi/src/options/opt_lookfeel_toolbars.ui to opt_toolbars-ui.ui

so the names are homogeneous for all the option tabs.

The following files could be deleted:

- psi/src/options/opt_lookfeel.cpp
- psi/src/options/opt_lookfeel.h

as they content a class which is not used anymore. The function of
that class is now done by "OptionsTabToolbars", which was called
"ToobarDlg" before and it can be found in the file toolbardlg.cpp.

I know, this is crazy, that's why the files should be renamed :D
Before this patch two classes were doing the work of one, and the
filenames and classnames didn't make sense...

Cheers,

Fran.

-- 
Francisco Joaquín Rodríguez Prados
Fachbereich Informatik,
Fachhochschule Darmstadt,
Darmstadt, Germany


More information about the Psi-devel-affinix.com mailing list