[Psi-devel] patch: no animation on DnD
kevin at kismith.co.uk
Mon Mar 21 05:32:21 PST 2005
-----BEGIN PGP SIGNED MESSAGE-----
Luke Worth wrote:
> I made a patch that works for me. It is currently unconfigurable, but i was
> hoping someone with a clue would add an option for it.
> I'm not sure whether this way is the right way or not.
> Also, i renamed the setTrayToolTip procedure to setTrayStatus, to reflect its
> more general purpose.
> I hope its not too dreadful, for a first-timer.
Thanks very much for the patch. I shall have a proper look at it in
advance of the next release. My only intial comment is that I'm not
personally fond of lines like:
d->icon = new AlertIcon(icon, d->status.show() != "dnd");
I'd rather see something like
bool dnd = ( d->status.show() != "dnd" );
d->icon = new AlertIcon(icon, dnd);
which I think is more readable, but that's just nitpicking.
Postgraduate Research Student
Department of Computer Science
University Of Exeter
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the Psi-devel-affinix.com