[Psi-devel] Again: Presence as empty message events

[Marian Cerny]

I wonder why this bug
http://listserver.dreamhost.com/pipermail/psi-devel-affinix.com/2005-April/002505.html
has not been fixed yet?

I have recently installed psi-0.10 on FreeBSD and found out this bug is
still in there. (Fortunately the other annoying bug with always reading
the whole history file before appending to it is fixed.)

I propose to change the code in function
iris/xmpp-im/xmpp_tasks.cpp: bool JT_PushPresence::take(const QDomElement &e)

from

        if(e.hasAttribute("type")) {
                QString type = e.attribute("type");
                if(type == "unavailable") {
                        p.setIsAvailable(false);
                }
                else if(type == "error") {
                        QString str = "";
                        int code = 0;
                        getErrorFromElement(e, &code, &str);
                        p.setError(code, str);
                }
                else {
                        subscription(j, type);
                        return true;
                }
        }

to

        if(e.hasAttribute("type")) {
                QString type = e.attribute("type");
                if(type == "unavailable") {
                        p.setIsAvailable(false);
                }
                else if(type == "error") {
                        QString str = "";
                        int code = 0;
                        getErrorFromElement(e, &code, &str);
                        p.setError(code, str);
                }
                else if(type == "subscribe"   ||
                        type == "subscribed"  ||
                        type == "unsubscribe" ||
                        type == "unsubscribed") {
                        subscription(j, type);
                        return true;
                }
        }

Will anybody from the Psi developers take care of it?

Thanks,

Marian Cerny