[Psi-devel] Submitting your patches

[Kevin Smith]

On 22 Nov 2006, at 11:13, Rafael Espíndola wrote:
>> You're right, patches should now be sent in a unified diff format,
>> not darcs bundles, although if you could send them to patches at psi-
>> im.org as well as to this list, it will help us :)
> ok. I will try to remember that :-)

Sorry - I intended, but forgot, to say please.

>> As to the content of the patches - I haven't looked at them yet, but
>> they seem to be patches to libjingle from the names,  and we're very
>> keen not to fork libjingle - perhaps you could try and get these
>> patches into the next version of libjingle?
>
> The libjingle development seems to have slowed down and they are not
> replying to emails :-(
I'm not quite sure what happened there.

> The tapioca project has a svn repository with a copy of lijingle that
> has some bugfixes and some nice new features (pkgconfig for example).
> If upstream libjingle starts to accept patches, I am sure this will be
> merge as fast as possible.
Yes, that would be good.

> My final goal is to remove the many different copies of libjingle
> present in the many projects. This will make debugging much easier for
> example.
This is one of the reasons we don't want to fork libjingle :)

> In order to do that, I started to remove one layer after the
> other. First port to a new ortp, then the mediastreamer. Now I am
> ready to try to use an external libjingle.
Once libjingle becomes externalisable (excuse the abuse of language  
please), things get more interesting, indeed.

> The libjingle copy in the tapioca svn doesn't has the session/phone
> directory. It was remove because of copyright issues (bsd code using
> lgpl (now gpl) library). Now that I have ported it to use an external
> mediastreamer I will try to add it back to the svn. If I can't, I will
> try make the copy on psy use an external version of libjingle.
I'm slightly curious as to whether it's really worth spending such a  
large amount of effort on libjingle, or whether it would be more  
productively spent on a new implementation - especially as libjingle  
doesn't support Jingle yet. I guess only time will tell.

Best,
/K

-- 
Kevin Smith
Psi XMPP Client Project Leader (http://psi-im.org)