[Psi-devel] Psi STARTTLS support with manual host or port and HTTP Connect proxy connectivity

[Michał Jazłowiecki]

Remko Tronçon wrote:
> Thanks for looking at that. Can you create a unified diff of the
> httpconnect patch ? The file(s) you sent are not really usable as they
> are (it's not a darcs bundle, and it's not a diff).

Unified diffs for both patches attached.

> Can you also briefly explain what the problem was in httpconnect ?

The code in extractLine(QByteArray *, bool *) (found in 
cutestuff/network/httpconnect.cpp) is supposed to analyse the header of 
HTTP Connect proxy response (as described in RFC 2616: Hypertext 
Transfer Protocol HTTP/1.1). However, due to strange operations on 
char*, sometimes Psi did not find the second empty line after the header 
and kept waiting for it. Proxy connection timed out and Psi had to 
reconnect.

I've replaced whole extractLine(QByteArray *, bool *) logic with QString 
method calls.


Regards,


-- 
Michał Jazłowiecki (michalj)
Psi Forum & Wiki Moderator :: Psi-Daisy Author
-------------- next part --------------
A non-text attachment was scrubbed...
Name: psi-michalj-fix-starttls-support-with-manual-host-or-port.diff
Type: text/x-patch
Size: 1145 bytes
Desc: not available
Url : http://lists.affinix.com/pipermail/psi-devel-affinix.com/attachments/20061126/55c27d9a/psi-michalj-fix-starttls-support-with-manual-host-or-port.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: psi-michalj-fix-http-connect-proxy-connectivity.diff
Type: text/x-patch
Size: 1242 bytes
Desc: not available
Url : http://lists.affinix.com/pipermail/psi-devel-affinix.com/attachments/20061126/55c27d9a/psi-michalj-fix-http-connect-proxy-connectivity.bin