[Psi-devel] Show/Hide in trayicon context menu not working correctly?

[Nikolay Mitev]

Hi

Michał Jazłowiecki wrote:
> Hello,
>
>
> I've observed that "Show" and "Hide" options in trayicon's context menu 
> seem not to work correctly, at least on Windows.
>
> Workflow:
> 1. Psi roster window is closed. Right-click on Psi's trayicon. There is 
> "Show" option at the top of the context-menu. CORRECT.
> 2. Click on the "Show" option. Psi roster window (re)appears. CORRECT.
> 3. Right-click on Psi's trayicon again. The top-most option still says 
> "Show", not the supposed "Hide". INCORRECT.
> 4. Clicking on the "Show" (which is invalid, as I noted above) option 
> does not hide the Psi roster window. This may be because "Show" and 
> "Hide" options are two distinct ones and not a single one with changing 
> name. Instead, the Psi's roster window is brought to front.
> 5. I have to click on [X] on Psi roster window's title bar to hide it.
>
> I'm using a fairly recent Psi-Darcs (last time I've checked my source 
> code with Darcs repository was on June 14, 2007), which I've compiled 
> myself using MinGW (gcc/g++-3.4.2 Windows port), Qt/OpenSource-4.2.3 and 
> OpenSSL-0.9.8e. I'm running this Psi on 32-bit Windows XP Professional 
> Service Pack 2 with all available patches. My Psi is configured to use 
> trayicon (which changes Psi window style to toolstrip).
>
> Does anyone experience the same?
>
>
> Regards,
>
>   

Yup, same here. Good job spotting that. Here's a patch

Index: src/mainwin.cpp
===================================================================
--- src/mainwin.cpp     (revision 730)
+++ src/mainwin.cpp     (working copy)
@@ -305,6 +305,7 @@
        buildToolbars();
 
        connect(d->psi->contactList(), SIGNAL(accountFeaturesChanged()), 
SLOT(accountFeaturesChanged()));
+        connect(d->trayMenu, SIGNAL(aboutToShow()), SLOT(buildTrayMenu()));
        accountFeaturesChanged();
 
        decorateButton(STATUS_OFFLINE);




cheers,
face