[Psi-devel] Patch reminder: small fixups, xep-0004/xep-0050 conformance
Roelof Naude
roelof.naude at epiuse.com
Thu Mar 22 00:18:34 PDT 2007
1. psi doesn't currently display xep-0004 reported items when executing
a command (xep-0050 example 8 and 9). the attached patch allows this.
i've tested against wildfire's admin commands (eg. Get list of group
members).
2. xep-0004 specifies that <instructions> may not contain '\n', instead
multiple <instructions> should be specified.
the following two patches implement that:
combine_text_of_similar_elements.patch -> added a method subTagsText
that will combine the text of similar xml elements
xdata_support_multiple_instructions.patch -> make use of subTagsText
added above.
3. here are patches to display <note> from adhoc commands:
3.1. psi.add_note_info_ahcommand.h.patch - add noteText_ & noteType_ to
ahcommand.h
3.2. psi.init_ahc_note.ahcommand.cpp.patch - initialize noteText_/Type_
from xml.
3.3. psi.display_ahc_note.patch - creates a QLabel for note display
purposes. i've concatenated the note type (info/warning/error) with the
note text. displaying an icon might be better?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ahcformdlg_display_reported_items.patch
Type: text/x-patch
Size: 1133 bytes
Desc: not available
Url : http://lists.affinix.com/pipermail/psi-devel-affinix.com/attachments/20070322/718ef4e5/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xdata_support_multiple_instructions.patch
Type: text/x-patch
Size: 334 bytes
Desc: not available
Url : http://lists.affinix.com/pipermail/psi-devel-affinix.com/attachments/20070322/718ef4e5/attachment-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: combine_text_of_similar_elements.patch
Type: text/x-patch
Size: 651 bytes
Desc: not available
Url : http://lists.affinix.com/pipermail/psi-devel-affinix.com/attachments/20070322/718ef4e5/attachment-0002.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: psi.add_note_info_ahcommand.h.patch
Type: text/x-patch
Size: 609 bytes
Desc: not available
Url : http://lists.affinix.com/pipermail/psi-devel-affinix.com/attachments/20070322/718ef4e5/attachment-0003.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: psi.display_ahc_note.patch
Type: text/x-patch
Size: 498 bytes
Desc: not available
Url : http://lists.affinix.com/pipermail/psi-devel-affinix.com/attachments/20070322/718ef4e5/attachment-0004.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: psi.init_ahc_note.ahcommand.cpp.patch
Type: text/x-patch
Size: 1378 bytes
Desc: not available
Url : http://lists.affinix.com/pipermail/psi-devel-affinix.com/attachments/20070322/718ef4e5/attachment-0005.bin
More information about the psi-devel
mailing list