[Psi-Devel] Bug#475748: psi: Segfault when clicking on Preferences -> Appearance

[textshell-I1QKlO at neutronstar.dyndns.org]

On Sun, Apr 13, 2008 at 05:34:21PM +0200, Jan Niehusmann wrote:
> On Sat, Apr 12, 2008 at 07:13:41PM +0200, Marek Elias wrote:
> > In prefernces window, when clicking on appearance, PSI segfaults:
> > kernel: [53510.815342] psi[28666]: segfault at 00000000 eip 083803a8 esp bfab5880 error 4
> > (from syslog)
> > 
> > You can find dumped core here: http://mebs.matfyz.cz/neporiadok/core.psi
> 
> I tracked this down to OptionsTabWidget::addTab(OptionsTab *tab), where
> QTabWidget::addTab() is called before initializing wtab[]. It seems like
> qt4.4 is triggering the currentChanged signal immediately on calling
> addTab(). As wtab[] has not been initialized at this point, the
> following code in updateCurrent() segfaults:
> 
>                 OptionsTab *opttab = w2tab[w].tab;
> 
>                 QWidget *tab = opttab->widget();
> 
> The fix is easy: Change OptionsTabWidget::addTab to call QTabWidget::addTab after
> initializing w2tab. (Patch below)
> 

Thanks for the problem analysis and the patch. 
Fix is applied.

 - Martin H.