[Psi-Devel] Fwd: Psi Jabber Client - FS#531: Add 'Save as' context menu for vcard photo

[textshell-I1QKlO at neutronstar.dyndns.org]

On Sun, Feb 10, 2008 at 12:29:33PM +0200, Mircea Bardac wrote:
> Hi,
> 
> Hal Rottenberg wrote:
> > +               if (!str.isEmpty())
> > +               {
> > +                       QFileInfo fi(str);
> > +
> > PsiOptions::instance()->getOption("options.ui.last-used-open-path").toString()=fi.dirPath();
> > +                       // Convert imge if required
> > +                       QImage img(d->photo);
> > +                       img.save(str);
> > +               }
> 
> I've seen Justin fixing a similar usage of PsiOptions in a recent commit:
> http://dev.psi-im.org/websvn/comp.php?repname=Psi&path=%2F&compare[]=%2F@1008&compare[]=%2F@1009
> 
> I might be wrong though, but shouldn't that line be
> PsiOptions::instance()->setOption(...) ?
> 
> (there might be more places where this happens)

Yes, that's right. 
There are some of these bugs in the tree too, and it's on my todo list to
fix the in tree bugs that I can find via grepping.

 - Martin H.