[Psi-Devel] Where to drop autotests? [Was: Re: idle_mac.cpp]
Aleksey "AlekSi" Palazhchenko
alek.silverstone at gmail.com
Wed Sep 2 13:20:34 PDT 2009
>> Also, after making the change the application crashes at
>> IdlePlatform::Private::IdleTimerAction where it tries to do
>> ((IdlePlatform::Private*)inUserData)->mSecondsIdle = 0. I am not a
>> C expert but I think the problem is related to having inUserData as
> Yes, it should be 'd'.
> I will send pull request to core developers shortly.
Actually, things were much more tricky.
1) Different platform implementations were 'asymmetrical' in a
interesting way. If there is no user activity, one of the returned
number of seconds since init() call, while other – since start() call.
2) Mac code detected inactivity only for Psi window. In other words,
old idle code says that I'm inactive for 5 minutes already, although
all this time I'm actively pushing buttons writing this mail (and
looking into dictionary :) ).
I wrote auto tests for this situations and patched idle code. So the
question is: where I should drop tests?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Psi-Devel